Skip to content

fix(Typography): text is rendered as HTML tags when ellipsis is enabled #4117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RylanBot wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(Typography): text is rendered as HTML tags when ellipsis is enabled #4117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36dfce5
fix(Text): text is rendered as HTML tags when `ellipsis` is enabled
RylanBot Feb 3, 2026
f371fd2
Merge branch 'develop' into rylan/fix/text/truncate
RylanBot Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/components/typography/ellipsis/Truncate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,21 @@ export default class Truncate extends React.Component<TruncateProps, TruncateSta
return this.createMarkup(content) as unknown as string;
};

escapeHtml = (html: string) =>
html
.replace(/&/g, '&amp;')
.replace(/</g, '&lt;')
.replace(/>/g, '&gt;')
.replace(/"/g, '&quot;')
.replace(/'/g, '&#39;');

// Shim innerText to consistently break lines at <br/> but not at \n
innerText = (node: HTMLElement) => {
const div = document.createElement('div');
const contentKey = 'innerText' in window.HTMLElement.prototype ? 'innerText' : 'textContent';

const content = node.innerHTML.replace(/\r\n|\r|\n/g, ' ');
const escapedHtml = this.escapeHtml(node.innerHTML);
const content = escapedHtml.replace(/\r\n|\r|\n/g, ' ');
div.innerHTML = this.extractReplaceLinksKeys(content);

let text = div[contentKey];
Expand Down
Loading