mostly cosmetic and very small changes#982
Open
EnthusiastNT wants to merge 1 commit intoThingEngineer:masterfrom
Open
mostly cosmetic and very small changes#982EnthusiastNT wants to merge 1 commit intoThingEngineer:masterfrom
EnthusiastNT wants to merge 1 commit intoThingEngineer:masterfrom
Conversation
EnthusiastNT
commented
Dec 4, 2021
EnthusiastNT
commented
-
- added a check on isset($table[0]) because that threw an error once
-
- utf8mb4 instead of utf8 as default as recommended in the docs
-
- mb_substr instead of substr since we use utf8
-
- added 3 function aliases for easier understanding (see CHANGED)
-
- corrected some spelling and grammar in comments
-
- removed a few "@throws Exception" where it wasn't throwing anything
-
- added some line breaks for consistency
-
- moved orWhere() after where() because... OCD I guess
* - added a check on isset($table[0]) because that threw an error once * - utf8mb4 instead of utf8 as default as recommended in the docs * - mb_substr instead of substr since we use utf8 * - added 3 function aliases for easier understanding (see CHANGED) * - corrected some spelling and grammar in comments * - removed a few "@throws Exception" where it wasn't throwing anything * - added some line breaks for consistency * - moved orWhere() after where() because... OCD I guess
Collaborator
|
@EnthusiastNT great cleanup thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.