Improve Toast appearance of "neutral" variant#1449
Merged
Conversation
proper style forks for "neutral" toasts, esp. dark scheme button
🦋 Changeset detectedLatest commit: 57c9b52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR improves the visual appearance of the "neutral" variant of the Toast component, with specific enhancements for dark mode. The changes ensure better contrast and consistency in the toast's styling across different color schemes.
- Improves styling for neutral toast variant with better background and foreground color handling
- Adds dynamic color scheme detection to properly style action buttons and close buttons
- Replaces hardcoded divider color with a dynamic CSS custom property for better theme integration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements better handling of "neutral" toast appearance, especially for dark mode.