Open
Conversation
|
Fynes seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5692
This pull request refactors the macro evaluation logic in
sqlmesh/core/macros.pyto introduce lazy loading for Python environments, improve error handling for missing macro dependencies, and enhance code readability. The changes enable projects to share state databases without requiring all external dependencies to be present, and provide clearer error messages when macros fail to load. Additionally, the code has been reformatted for better readability, and error messages have been made more consistent throughout the file.Macro Environment Loading and Error Handling:
_unloaded_executablesand_failed_importstracking, and refactored macro loading logic into a new_load_python_envmethod. (sqlmesh/core/macros.py) [1] [2]sqlmesh/core/macros.py)Code Readability and Consistency:
sqlmesh/core/macros.py) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]Error Message Improvements:
sqlmesh/core/macros.py) [1] [2] [3] [4] [5] [6] [7] [8]General Cleanup:
prepare_envfrom the file. (sqlmesh/core/macros.py)These changes make the macro evaluation system more robust, maintainable, and easier for users to debug when issues arise.