-
Notifications
You must be signed in to change notification settings - Fork 2
chore: improve Event property #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- correctly expand `anyOf` for events - add a maxItems to auctions array - CategoryDisjunctions incorrectly refers to `minimum` instead of `minLength`
Right now its painful to test, but the most straightforward solution is to have the You can also test via another tool such as scalar, but there's no guarantee they will render it the same way: https://docs.scalar.com/editor#/reference |
sk-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also fix the warnings in another PR?
yeah i have a draft branch that takes a pass at many warnings |
jilanglois
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! My only concern is that a user looking at the docs understands that they can send more than one option at a time. I believe some of the examples do show this use case so it might be fine.
sk-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments about unused objects.
Could you also update the PR description to reflect the current changes.
anyOfand properties for the Event schemaminimuminstead ofminLengthCloses: #186