Skip to content

Conversation

@jbergstroem
Copy link
Member

@jbergstroem jbergstroem commented Nov 10, 2025

  • merge anyOf and properties for the Event schema
  • add a maxItems to auctions array and use discriminator to explain the type relationship
  • CategoryDisjunctions incorrectly refers to minimum instead of minLength

Closes: #186

- correctly expand `anyOf` for events
- add a maxItems to auctions array
- CategoryDisjunctions incorrectly refers to `minimum` instead of `minLength`
@jbergstroem jbergstroem requested a review from a team as a code owner November 10, 2025 14:10
@jbergstroem jbergstroem marked this pull request as draft November 10, 2025 14:14
@jbergstroem jbergstroem marked this pull request as ready for review November 10, 2025 15:56
@jbergstroem
Copy link
Member Author

jbergstroem commented Nov 10, 2025

I looked at a preview of the documentation and the anyOf properties where not displayed correctly. How can we test it looks ok?

Right now its painful to test, but the most straightforward solution is to have the mintlify-docs repo running locally, copy over the yaml into the docs repo which has a process to merge documents, then review it in the live dev environment.

You can also test via another tool such as scalar, but there's no guarantee they will render it the same way: https://docs.scalar.com/editor#/reference

Copy link
Contributor

@sk- sk- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also fix the warnings in another PR?

@jbergstroem
Copy link
Member Author

jbergstroem commented Nov 10, 2025

Could we also fix the warnings in another PR?

yeah i have a draft branch that takes a pass at many warnings

@jbergstroem jbergstroem requested a review from sk- November 10, 2025 16:48
Copy link
Contributor

@jilanglois jilanglois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! My only concern is that a user looking at the docs understands that they can send more than one option at a time. I believe some of the examples do show this use case so it might be fine.

Copy link
Contributor

@sk- sk- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments about unused objects.

Could you also update the PR description to reflect the current changes.

@jbergstroem jbergstroem requested a review from sk- November 10, 2025 17:32
@jbergstroem jbergstroem merged commit d2c1cd4 into main Nov 10, 2025
6 checks passed
@jbergstroem jbergstroem deleted the chore/event-improvement branch November 10, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants