Improved search to match on name, handle, and domain #1460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref https://linear.app/ghost/issue/BER-3094 Previously, search only matched on name prefix. Now it: - Matches on name, handle (`@user@domain`), and domain using contains matching - Ranks results by match quality: `name starts with` > `name contains` > `handle starts with` > `handle contains` > `domain starts with` > `domain contains` - Falls back to external WebFinger lookup (only when no local results found search query is a handle) This makes it easier to find accounts by typing partial handles or domains rather than requiring users to know the exact display name
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/ghost/issue/BER-3094
Previously, search only matched on name prefix. Now it:
@user@domain), and domain using contains matchingname starts with>name contains>handle starts with>handle contains>domain starts with>domain containssearch query is a handle)
This makes it easier to find accounts by typing partial handles or domains rather than requiring users to know the exact display name