Fix dewpoint formula inconsistency with saturation_vapor_pressure (#3976)#3980
Closed
xtian15 wants to merge 2 commits intoUnidata:mainfrom
Closed
Fix dewpoint formula inconsistency with saturation_vapor_pressure (#3976)#3980xtian15 wants to merge 2 commits intoUnidata:mainfrom
xtian15 wants to merge 2 commits intoUnidata:mainfrom
Conversation
Add 'method' parameter to dewpoint() with options: - 'bolton' (default): Original analytical formula, preserves backward compatibility - 'ambaum': Numerical inversion of Ambaum (2020), consistent with saturation_vapor_pressure() This allows users who need thermodynamic consistency to use: dewpoint(e, method='ambaum') which satisfies: dewpoint(saturation_vapor_pressure(T), method='ambaum') == T - Add _dewpoint_ambaum() helper using scipy.optimize.brentq - Add test_dewpoint_ambaum_roundtrip() verifying consistency - Document both methods in docstring with examples Addresses #3976
1a61298 to
7ec4570
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
methodparameter todewpoint()allowing users to choose between:'bolton'(default): Original analytical formula - preserves backward compatibility'ambaum': Numerical inversion of Ambaum (2020), consistent withsaturation_vapor_pressure()Problem
As reported in #3976,
saturation_vapor_pressure()uses Ambaum (2020) butdewpoint()inverts Bolton (1980). This causes round-trip inconsistency:Changes
Benefits
Testing
All 228 tests pass (227 existing + 1 new round-trip test).
Addresses #3976