Add check to make sure that program name and save path is specified w…#447
Open
URJala wants to merge 5 commits intoUniversalRobots:masterfrom
Open
Add check to make sure that program name and save path is specified w…#447URJala wants to merge 5 commits intoUniversalRobots:masterfrom
URJala wants to merge 5 commits intoUniversalRobots:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #447 +/- ##
==========================================
- Coverage 76.36% 76.06% -0.30%
==========================================
Files 105 105
Lines 5539 5545 +6
Branches 593 594 +1
==========================================
- Hits 4230 4218 -12
- Misses 1011 1029 +18
Partials 298 298
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
urfeex
reviewed
Mar 2, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
…hen downloading program. Also renamed the input parameter for clarity
7a59a8b to
18df74e
Compare
urfeex
approved these changes
Mar 5, 2026
urfeex
requested changes
Mar 5, 2026
Member
urfeex
left a comment
There was a problem hiding this comment.
Please add test cases for
- program_name empty
- save_path empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hen downloading program.
Also renamed the input parameter for clarity
Note
Low Risk
Small, localized change to download-program plumbing and input validation; main risk is minor behavior change for callers previously passing empty strings.
Overview
commandDownloadProgram(WithResponse)now consistently uses the parameter nameprogram_name(instead offilename) across the publicDashboardClientAPI and both G5/X implementations, including updated docs.On the PolyScope X implementation, downloading a program now fails fast with a clear error
DashboardResponsewhen eitherprogram_nameorsave_pathis empty, instead of issuing the HTTP request.Written by Cursor Bugbot for commit 18df74e. This will update automatically on new commits. Configure here.