Skip to content

Add check to make sure that program name and save path is specified w…#447

Open
URJala wants to merge 5 commits intoUniversalRobots:masterfrom
URJala:dashboard_x_input_validation
Open

Add check to make sure that program name and save path is specified w…#447
URJala wants to merge 5 commits intoUniversalRobots:masterfrom
URJala:dashboard_x_input_validation

Conversation

@URJala
Copy link
Collaborator

@URJala URJala commented Feb 26, 2026

…hen downloading program.

Also renamed the input parameter for clarity


Note

Low Risk
Small, localized change to download-program plumbing and input validation; main risk is minor behavior change for callers previously passing empty strings.

Overview
commandDownloadProgram(WithResponse) now consistently uses the parameter name program_name (instead of filename) across the public DashboardClient API and both G5/X implementations, including updated docs.

On the PolyScope X implementation, downloading a program now fails fast with a clear error DashboardResponse when either program_name or save_path is empty, instead of issuing the HTTP request.

Written by Cursor Bugbot for commit 18df74e. This will update automatically on new commits. Configure here.

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.06%. Comparing base (c2e7fe5) to head (18df74e).

Files with missing lines Patch % Lines
src/ur/dashboard_client_implementation_x.cpp 18.18% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
- Coverage   76.36%   76.06%   -0.30%     
==========================================
  Files         105      105              
  Lines        5539     5545       +6     
  Branches      593      594       +1     
==========================================
- Hits         4230     4218      -12     
- Misses       1011     1029      +18     
  Partials      298      298              
Flag Coverage Δ
start_ursim 83.57% <ø> (-0.49%) ⬇️
ur20-latest 68.59% <21.42%> (-0.14%) ⬇️
ur5-3.14.3 71.63% <21.42%> (-0.31%) ⬇️
ur5e-10.11.0 64.49% <21.42%> (-0.39%) ⬇️
ur5e-10.12.0 65.75% <28.57%> (-0.48%) ⬇️
ur5e-10.7.0 64.14% <14.28%> (-0.12%) ⬇️
ur5e-5.9.4 72.30% <21.42%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@URJala URJala force-pushed the dashboard_x_input_validation branch from 7a59a8b to 18df74e Compare March 5, 2026 10:24
Copy link
Member

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test cases for

  • program_name empty
  • save_path empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants