Skip to content

Conversation

@amrit110
Copy link
Member

This pull request introduces a new agent evaluation framework for knowledge-grounded question answering (QA) using Gemini's Google Search grounding, along with rich display utilities for evaluation outputs. It adds well-structured modules for agent implementation, configuration, evaluation, and user-friendly display, and updates environment and linting configurations to support the new features.

Agent and Evaluation Framework:

  • Introduced a knowledge-grounded QA agent leveraging Gemini's Google Search grounding, including synchronous and asynchronous answering, response parsing, and citation formatting, with clear system instructions and guidelines. (aieng-eval-agents/aieng/agent_evals/knowledge_agent/agent.py)
  • Added an asynchronous client manager for efficient resource management and lifecycle control of agent and grounding tool instances. (aieng-eval-agents/aieng/agent_evals/knowledge_agent/agent.py)
  • Provided a comprehensive package initialization for the knowledge agent, exposing all key classes for agent creation, configuration, evaluation, and session management. (aieng-eval-agents/aieng/agent_evals/knowledge_agent/__init__.py)
  • Added a package-level __init__.py to expose display utilities and document the agent evaluation tools. (aieng-eval-agents/aieng/agent_evals/__init__.py)

Display and Usability Enhancements:

  • Implemented rich display utilities for Jupyter and console, including functions for displaying responses, comparisons, evaluation results, metrics tables, and styled messages, all using the rich library for improved readability and user experience. (aieng-eval-agents/aieng/agent_evals/display.py)

Configuration and Tooling:

  • Updated the example environment file to include Gemini/OpenAI-compatible LLM settings and optional LangFuse tracing configuration, replacing placeholder variables with relevant API keys and model selection options. (.env.example)
  • Expanded pre-commit linting rules to ignore additional style and import errors, improving development workflow for the new codebase. (.pre-commit-config.yaml)

@amrit110 amrit110 self-assigned this Jan 26, 2026
@amrit110 amrit110 added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jan 26, 2026
@amrit110 amrit110 force-pushed the feature/knowledge-agent branch from 3333793 to bbabc9e Compare January 27, 2026 14:03
@amrit110 amrit110 marked this pull request as ready for review January 27, 2026 14:05
@amrit110 amrit110 merged commit 9549395 into main Jan 27, 2026
3 checks passed
@amrit110 amrit110 deleted the feature/knowledge-agent branch January 27, 2026 14:05
"""


class KnowledgeGroundedAgent:
Copy link
Collaborator

@fcogidi fcogidi Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really an agent. It doesn't follow the "LLM + tools + loop" format or the ReAct framework introduced in the agent bootcamp. It's tricky in this case, since the tool itself is agent-like.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thanks will update it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops this got merged by mistake. Need to revert it.

amrit110 added a commit that referenced this pull request Jan 27, 2026
…stitute/eval-agents into feature/knowledge-agent (#17)"

This reverts commit 9549395.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants