Add deployment of aarch64-pc-cygwin-msvcrt toolchain
#320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackhex
force-pushed
the
variant-yml
branch
3 times, most recently
from
794ef87 to
cd1ae51
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds deployment support for the new aarch64-pc-cygwin-msvcrt toolchain by downloading its artifacts and including them in the release assets.
- Insert download-artifact steps for
aarch64-pc-cygwin-msvcrt-toolchainand runtime - Update the release assets list to include the new
.tar.gzfiles
Comments suppressed due to low confidence (3)
.github/workflows/rebase.yml:404
- The download-artifact step uses the artifact name without the
.tar.gzextension, but the release-upload step expectsaarch64-pc-cygwin-msvcrt-toolchain.tar.gz. Ensure the artifact name matches the file name or adjust the files list accordingly.
- - name: Download `aarch64-pc-cygwin-msvcrt` toolchain artifact
.github/workflows/rebase.yml:404
- Add a
pathfield to the download-artifact steps (e.g.,path: .) so the downloaded.tar.gzfiles are placed in the workspace root for the release-upload step to find them.
- - name: Download `aarch64-pc-cygwin-msvcrt` toolchain artifact
.github/workflows/rebase.yml:404
- [nitpick] Avoid using backticks in the step name; wrap the full string in quotes or remove the backticks to prevent potential YAML parsing or formatting issues.
- - name: Download `aarch64-pc-cygwin-msvcrt` toolchain artifact
aarch64-pc-cygwin-msvcrt toolchainaarch64-pc-cygwin-msvcrt toolchain
Blackhex
force-pushed
the
variant-yml
branch
4 times, most recently
from
c92e8d8 to
a75d7bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releasing Cygwin toolchain here will allow add AArch64 Cygwin build to https://github.com/Windows-on-ARM-Experiments/newlib-cygwin/blob/woarm64/.github/workflows/cygwin.yml