-
Notifications
You must be signed in to change notification settings - Fork 69
Fix devcontainer #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix devcontainer #155
Conversation
|
/review |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
/improve |
User description
Type of Change
Related Issues
Breaking Changes
Checklist
Additional Context
PR Type
Enhancement, Documentation
Description
Configure devcontainer with named volumes for cache and venv.
Bind-mount local SSH keys into the devcontainer.
Update Ruff configuration with new ignore rules and Python target.
Streamline VSCode interpreter paths to use relative paths.
Diagram Walkthrough
flowchart LR A[devcontainer.json] --> B{Add Mounts}; B -- "Cache Volume" --> C[/.cache]; B -- "Venv Volume" --> D[/.venv]; B -- "SSH Bind Mount" --> E[/.ssh]; A -- "Update UV_PROJECT_ENVIRONMENT" --> F[Environment Variables]; A -- "Add updateContentCommand" --> G[File Ownership]; A -- "Update VSCode Extensions" --> H[VSCode Configuration]; I[.vscode/settings.json] --> J[Relative Paths]; K[docs/configurations/ruff.md] --> L[Ruff Configuration Updates]; M[docs/configurations/uv.md] --> N[Devcontainer Docs Update]; O[docs/usecases/jupyter.md] --> J;File Walkthrough
devcontainer.json
Configure devcontainer with named volumes and SSH bind mount..devcontainer/devcontainer.json
mountsforcache,venv, andSSHkeys using named volumesand bind mounts.
UV_PROJECT_ENVIRONMENTto use${containerWorkspaceFolder}/.venv.updateContentCommandto manage file ownership for mountedvolumes.
astral-sh.tyanddorzey.vscode-sqlfluff.settings.json
Use relative paths for Python interpreter and SQLFluff..vscode/settings.json
python.defaultInterpreterPathfrom an absolute path to arelative
.venv/bin/python.sqlfluff.configandsqlfluff.executablePathto use relativepaths.
ruff.md
Update Ruff configuration documentation with new rules and target.docs/configurations/ruff.md
configurations.
PLC0415to the list of ignored Ruff rules.[lint.per-file-ignores]to ignoreINP001andS101fortests/**.target-versionfor Ruff topy314.uv.md
Document new devcontainer UV configuration with volume mounts.docs/configurations/uv.md
Dockerfileexample with a detaileddevcontainer.jsonconfiguration.
mountssection for cache, venv, and SSH keys.UV_PROJECT_ENVIRONMENTvariable andupdateContentCommand.jupyter.md
Adjust Jupyter documentation for relative Python interpreter path.docs/usecases/jupyter.md
python.defaultInterpreterPathto use a relative path.venv/bin/python.