-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Update js-yaml to 4.1.1 #3110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update js-yaml to 4.1.1 #3110
Conversation
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.13.1 to 4.1.1. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.13.1...4.1.1) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.1.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…/validate-data/js-yaml-4.1.1
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.13.1 to 4.1.1. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.13.1...4.1.1) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.1.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…/sync-ghes/js-yaml-4.1.1 Bump js-yaml from 3.13.1 to 4.1.1 in /script/sync-ghes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the js-yaml dependency from version 3.13.1 to 4.1.1 in both the sync-ghes and validate-data scripts, along with related dependency updates. However, this PR is incomplete and will cause runtime failures because it does not update the code to handle breaking API changes introduced in js-yaml 4.x (specifically, safeLoad has been removed and replaced with load).
Key Changes
- Upgraded
js-yamlfrom^3.13.1to^4.1.1in both scripts' package.json files - Updated
argparsedependency from 1.0.10 to 2.0.1 (transitive dependency of js-yaml) - Removed
esprimaandsprintf-jspackages that are no longer needed by js-yaml 4.x
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| script/validate-data/package.json | Updated js-yaml version to 4.1.1, but missing required code changes for breaking API |
| script/validate-data/package-lock.json | Updated lockfile with new js-yaml 4.1.1, argparse 2.0.1, and removed obsolete dependencies |
| script/sync-ghes/package.json | Updated js-yaml version to 4.1.1, but missing required code changes for breaking API |
| script/sync-ghes/package-lock.json | Updated lockfile with new js-yaml 4.1.1, argparse 2.0.1, and removed obsolete dependencies |
Files not reviewed (2)
- script/sync-ghes/package-lock.json: Language not supported
- script/validate-data/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JaclynCodes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JaclynCodes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request updates the
js-yamldependency from version 3.13.1 to 4.1.1 in both thesync-ghesandvalidate-datascripts. As part of this upgrade, related dependencies are updated, and unused transitive dependencies are removed, resulting in a cleaner dependency tree and better compatibility with newer Node.js versions.Dependency upgrades and cleanup:
js-yamlfrom^3.13.1to^4.1.1in bothscript/sync-ghes/package.jsonandscript/validate-data/package.json, as well as their respectivepackage-lock.jsonfiles. [1] [2] [3] [4]argparsedependency from version1.0.10to2.0.1, reflecting changes in the dependency tree for both scripts. [1] [2] [3] [4]esprimaandsprintf-jsas transitive dependencies, which are no longer required by the updated version ofjs-yamlandargparse. [1] [2] [3] [4] [5] [6] [7] [8]These changes improve security and maintainability by keeping dependencies up to date and removing unnecessary packages.<!--
IMPORTANT:
This repository contains configuration for what users see when they click on the
Actionstab and the setup page for Code Scanning.It is not:
-->
Pre-requisites
Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.
Tasks
For all workflows, the workflow:
.ymlfile with the language or platform as its filename, in lower, kebab-cased format (for example,docker-image.yml). Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").GITHUB_TOKENso that the workflow runs successfully.For CI workflows, the workflow:
cidirectory.ci/properties/*.properties.jsonfile (for example,ci/properties/docker-publish.properties.json).pushtobranches: [ $default-branch ]andpull_requesttobranches: [ $default-branch ].releasewithtypes: [ created ].docker-publish.yml).For Code Scanning workflows, the workflow:
code-scanningdirectory.code-scanning/properties/*.properties.jsonfile (for example,code-scanning/properties/codeql.properties.json), with properties set as follows:name: Name of the Code Scanning integration.creator: Name of the organization/user producing the Code Scanning integration.description: Short description of the Code Scanning integration.categories: Array of languages supported by the Code Scanning integration.iconName: Name of the SVG logo representing the Code Scanning integration. This SVG logo must be present in theiconsdirectory.pushtobranches: [ $default-branch, $protected-branches ]andpull_requesttobranches: [ $default-branch ]. We also recommend ascheduletrigger ofcron: $cron-weekly(for example,codeql.yml).Some general notes:
actionsorganization, or