Skip to content

Conversation

@telus-terchu
Copy link

Motivation

INTERLOK-4477: Upgrade jakarta and jetty, make release version 5.1-SNAPSHOT

Modification

Updated necessary dependencies and imports to use jakarta instead of javax

PR Checklist

  • been self-reviewed.
  • Added javadocs for most classes and all non-trivial methods
  • Added supporting annotations (like @XStreamAlias / @ComponentProfile)
  • Added DefaultValue annotation when there is a default value (e.g. @DefaultValue('true'))
  • Added validation annotation (@NotNull...) when required and add @Valid when nested class has some validation
  • Checked that @NotNull and @notblank annotations have a meaningful message when appropriate.
  • Checked that new 3rd party dependencies are appropriately licensed
  • Added comments explaining the "why" and the intent of the code wherever it would not be obvious for an unfamiliar reader
  • Added unit tests or modified existing tests to cover new code paths
  • Tested new/updated components in the UI and at runtime in an Interlok instance
  • Reviewed java class members so that missing annotations are added (InputFieldDefault/ComponentProfile etc)
  • Checked that javadoc generation doesn't report errors
  • Checked the display of the component in the UI
  • Remove any config/license annotations
  • Check the gradle build file to make sure the dependencies section is more explicit "implementation/api".

Result

Compatibility with future versions of jakarta/jetty

Testing

@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.16%. Comparing base (c61e9e6) to head (6cf298b).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #602   +/-   ##
==========================================
  Coverage      99.16%   99.16%           
  Complexity       469      469           
==========================================
  Files             74       74           
  Lines           1197     1197           
  Branches          74       74           
==========================================
  Hits            1187     1187           
  Misses             5        5           
  Partials           5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants