Skip to content

fix DEXPI validation error: allow SubmodelElement 'ModelFile' as valid predecessor for FragmentReference #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kommerzienrat wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix DEXPI validation error: allow SubmodelElement 'ModelFile' as valid predecessor for FragmentReference #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions aas_test_engines/test_cases/v3_0/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,14 +379,22 @@ def check_aasd_127(self):
more than one key in Reference/keys, a key with Key/type FragmentReference shall be preceded by a key
with Key/type File or Blob. All other Asset Administration Shell fragments, i.e. Key/type values out of
AasSubmodelElements, do not support fragments.

DEXPI Exception: In DEXPI-compliant RelationshipElements, a SubmodelElement with value="ModelFile" is
also accepted as a valid predecessor to FragmentReference.
"""
if self.type != ReferenceType.ModelReference or self.keys is None or len(self.keys) <= 1:
return
for idx, key in enumerate(self.keys):
if key.type == KeyType.FragmentReference and idx >= 1:
if self.keys[idx - 1].type not in {KeyType.File, KeyType.Blob}:
prev_key = self.keys[idx - 1]
valid_predecessors = {KeyType.File, KeyType.Blob}
# DEXPI exception: Allow SubmodelElement with value="ModelFile"
if prev_key.type == KeyType.SubmodelElement and prev_key.value.raw_value == "ModelFile":
valid_predecessors.add(KeyType.SubmodelElement)
if prev_key.type not in valid_predecessors:
raise CheckConstraintException(
f"Constraint AASd-127 violated: key {idx} must be preceded by File or Blob"
f"Constraint AASd-127 violated: key {idx} must be preceded by File, Blob, or SubmodelElement 'ModelFile'"
)

def check_aasd_128(self):
Expand Down