This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Adding 64 bit binaries for CodeHelper.exe#14784
Closed
g-217 wants to merge 1 commit intoadobe:masterfrom
g-217:Windows-x64
Closed
Adding 64 bit binaries for CodeHelper.exe#14784g-217 wants to merge 1 commit intoadobe:masterfrom g-217:Windows-x64
g-217 wants to merge 1 commit intoadobe:masterfrom
g-217:Windows-x64
Conversation
…his binary to be same as brackets, corresponding to brackets-shell/Windows-x64 branch
Contributor
Author
|
@swmitra @vickramdhawal @shubhsnov please have a look, this is corresponding to brackets-shell PR |
Contributor
Author
|
My changes are in forked repo |
Collaborator
|
Should the forked repo be brought under or adobe org ? It will be difficult to track the source of this change. Even the readme or wiki needs to be updated to identify the source of the 64bit binary. |
Collaborator
|
VSCode 64bit binary is still using the 32bit filewatcher, and since you haven't changed anything specific in the source, rather just the build platform, I'm not sure about this. A better approach would be to raise these forked changes as a PR against upstream, and see the response there. |
Contributor
Author
|
Yes "Any CPU" is good enough. So, don't need 64 bit build, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
have changed the icon for this binary to be same as brackets, corresponding to brackets-shell/Windows-x64 branch PR