[add] irrelevant & antisym to Pointwise for Data.Vec #2902
Merged
+41
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes:
I also checked the corresponding module in
Data.List, and I found out thatData.Listalready have the corresponding definitions, but the naming is not consistent:Data.Vecusesrefl,sym,trans(and here I addantisym)Data.Listusesreflexive,symmetric,transitive, andantisymmetricPerhaps the naming should be unified, but I do not know enough for this.
Regarding relaxing the level restrictions,
symmtricandtransitivein List.Pointwise is already level-polymorphic (the input relations R and S can have different levels) thanks to its use of generalisable variables.