Skip to content

feat: Stabilize Session Config Options #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
benbrandt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Stabilize Session Config Options #411

benbrandt wants to merge 1 commit into from

Conversation

@benbrandt
Copy link
Member

@benbrandt benbrandt commented Jan 27, 2026

Proposing to move this to the Completed stage!

@benbrandt benbrandt requested a review from a team as a code owner January 27, 2026 12:10
@chazcb
Copy link

chazcb commented Jan 27, 2026

@benbrandt would love if you took a quick look at #393 and the different config schema there. It might make sense to consolidate the way we define config schemas together.

@benbrandt
Copy link
Member Author

benbrandt commented Jan 27, 2026

@chazcb a few thoughts:

  • First: sorry for not doing a full review on that one sooner
  • Second: we made session config options possible to add new variants in the future, so I don't think it is at odds
  • Third: Session config options has something yours doesn't yet, which is the ability to have a distinction between values and labels, i.e. a unique ID and a user-facing value, but we can address that on your RFD

@chazcb chazcb mentioned this pull request Jan 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benbrandt @chazcb @nikomatsakis