Update 0162.md #1127
Open
Update 0162.md #1127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The solution for a question in the API readability exam says tagging requires (not accepts) a revision ID, so should this be updated?
toumorokoshi
reviewed
Jun 6, 2023
Contributor
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
Thanks for the contribution! can you add a changelog entry too? at the bottom of the page.
Contributor
|
In this case, I think the intention is to require a revision. should is used a bit liberally in the AIPs today, and I think we need to make them must unless we have a good reason not to. Thank you for the change! |
Author
|
sure added to changelog |
Contributor
|
@hrasadi if you have a chance, can you look at this 2-liner PR as second reviewer? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution for a question in the API readability exam says tagging requires (not accepts) a revision ID, so should this be updated?