feat AIP-127: Add comment that multiple binding allows mixed POST and GET #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Moving Angie off and adding @noahdietz since he has context and valid concerns. |
toumorokoshi
reviewed
Jul 6, 2023
| body: "book" | ||
| } | ||
| additional_bindings: { | ||
| get: "/v1/books:Create" |
Contributor
There was a problem hiding this comment.
regardless of whether we allow GET / POST mappings, we definitely shouldn't add this example - this is a Create RPC, and creates must use POST along with map to a resource pattern: https://google.aip.dev/133#guidance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat AIP-127: Add comment that multiple binding allows mixed POST and GET