Skip to content

fix(AIP-164): mutations return failed_precondition #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noahdietz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(AIP-164): mutations return failed_precondition #1579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions aip/general/0164.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,12 @@ purging those resources, including automatic purging after a reasonable time
the resources indefinitely. Regardless of what strategy is selected, the API
**should** document when soft deleted resources will be completely removed.

### Mutations

Soft-deleted resources **should not** be mutable and mutating methods **should**
return a `FAILED_PRECONDITION` error. This applies to Standard Update
(AIP-134) and mutating custom methods (AIP-136).

### Declarative-friendly resources

Soft-deletable resources have a poorer experience than hard-deleted resources in
Expand Down Expand Up @@ -148,6 +154,7 @@ resource is not deleted, the service **must** respond with `ALREADY_EXISTS`

## Changelog

- **2025-11-18**: Include expected behavior of mutating soft-deleted resource.
- **2024-09-24**: Included missing requirement for `delete_time`.
- **2023-07-13**: Renamed overloaded `expire_time` to `purge_time`.
- **2021-07-12**: Added error behavior when soft deleting a deleted resource.
Expand Down