Removing warning caused by Cops having a wrong namespace#208
Closed
santiagorodriguez96 wants to merge 2 commits intoairbnb:mainfrom
Closed
Removing warning caused by Cops having a wrong namespace#208santiagorodriguez96 wants to merge 2 commits intoairbnb:mainfrom
santiagorodriguez96 wants to merge 2 commits intoairbnb:mainfrom
Conversation
As part of the PR for adding support for Ruby 3.3 (airbnb#205) we bumped the `rubocop-rspec` dependency to `~> 2.26`, which depends on `rubocop-capybara` `~> 2.17` and `rubocop-factory_bot` `~> 2.22`. On those versions, the `RSpec` namespace was removed from their cops hence a warning was being logged when running `rubocop` with the last version of this gem. Related PRs: - rubocop/rubocop-factory_bot@812771e - rubocop/rubocop-capybara@e36f304
|
When will this be merged? |
rmaspero
approved these changes
Mar 11, 2025
rmaspero
left a comment
rmaspero
left a comment
There was a problem hiding this comment.
Keen for this to be merged if possible
Contributor
Author
|
Closing in favor of #212 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As part of the PR for adding support for Ruby 3.3 we bumped the
rubocop-rspecdependency to~> 2.26, which depends onrubocop-capybara~> 2.17andrubocop-factory_bot~> 2.22.On those versions, the
RSpecnamespace was removed from their cops hence a warning was being logged when runningrubocopwith the last version of this gem.Related PRs: