Skip to content

fix(interactive): Fix linkage for libflex_utils #4419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhanglei1949 merged 2 commits into from
Jan 15, 2025
Merged

fix(interactive): Fix linkage for libflex_utils #4419

zhanglei1949 merged 2 commits into from
Jan 15, 2025

Conversation

@zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Jan 13, 2025 •
edited
Loading

Link PROTOBUF_libraries for libflex_utils and by default use dynamic arrow libraries.

Fix #4416
Fix #4430

@zhanglei1949 zhanglei1949 requested a review from liulx20 January 13, 2025 03:53
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited
Loading

Please check the preview of the documentation changes at
https://cea52d80.graphscope-docs-preview.pages.dev

liulx20
liulx20 previously approved these changes Jan 14, 2025
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@f8250fb). Learn more about missing BASE report.
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4419   +/-   ##
=======================================
  Coverage        ?   33.11%           
=======================================
  Files           ?      126           
  Lines           ?    13261           
  Branches        ?        0           
=======================================
  Hits            ?     4391           
  Misses          ?     8870           
  Partials        ?        0

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8250fb...1ffcdcd. Read the comment docs.

@zhanglei1949 zhanglei1949 merged commit 0e2db7c into alibaba:main Jan 15, 2025
38 of 39 checks passed
@zhanglei1949 zhanglei1949 mentioned this pull request Jan 17, 2025
Merged
zhanglei1949 added a commit that referenced this pull request Jan 17, 2025
@zhanglei1949
fix(interactive): Use static arrow when building interactive image (#…
76097db 
…4432)

In #4419, Interactive is changed to link to dynamic arrow lib but forgot
to change the image building, where we need a static library for arrow.
@zhanglei1949 zhanglei1949 deleted the fix-proto-dep branch February 5, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidongze0629 lidongze0629 lidongze0629 approved these changes

@liulx20 liulx20 liulx20 approved these changes

@siyuan0322 siyuan0322 Awaiting requested review from siyuan0322

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Opentelemtry is not correctly installed with gsctl.py install_dep [BUG] libflex_utils should link PROTOBUF_libraries

4 participants

@zhanglei1949 @codecov-commenter @lidongze0629 @liulx20