-
Notifications
You must be signed in to change notification settings - Fork 461
fix(analytical): Fix WCC's wrong result #4623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@zhanglei1949 please help a review |
zhanglei1949
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4623 +/- ##
==========================================
- Coverage 33.02% 30.49% -2.53%
==========================================
Files 127 127
Lines 13299 13316 +17
==========================================
- Hits 4392 4061 -331
- Misses 8907 9255 +348 see 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
/cc @yecol @sighingnow, this issus/pr has had no activity for a long time, please help to review the status and assign people to work on it. |
|
@zhanglei1949 could you help merge this PR? |
|
@songqing Could you run the failed checks? |
@zhanglei1949 hi master, the failed UT before seems have nothing to do with my PR, and I rebase my PR now, please help trigger the check |
What do these changes do?
When run this WCC algorithm with only one worker, the algorithm will only compute one iteration, so as to cause wrong result.
Fix by add ForceContinue() in PEval() when needed.