Skip to content

Conversation

@songqing
Copy link
Contributor

What do these changes do?

When run this WCC algorithm with only one worker, the algorithm will only compute one iteration, so as to cause wrong result.
Fix by add ForceContinue() in PEval() when needed.

@songqing
Copy link
Contributor Author

@zhanglei1949 please help a review

Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.49%. Comparing base (7ec6d6c) to head (96f1da6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4623      +/-   ##
==========================================
- Coverage   33.02%   30.49%   -2.53%     
==========================================
  Files         127      127              
  Lines       13299    13316      +17     
==========================================
- Hits         4392     4061     -331     
- Misses       8907     9255     +348     

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 613a464...96f1da6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the stale label Oct 12, 2025
@github-actions
Copy link
Contributor

/cc @yecol @sighingnow, this issus/pr has had no activity for a long time, please help to review the status and assign people to work on it.

@songqing
Copy link
Contributor Author

@zhanglei1949 could you help merge this PR?

@github-actions github-actions bot removed the stale label Nov 12, 2025
@zhanglei1949
Copy link
Collaborator

@songqing Could you run the failed checks?

@songqing
Copy link
Contributor Author

songqing commented Dec 5, 2025

@songqing Could you run the failed checks?

@zhanglei1949 hi master, the failed UT before seems have nothing to do with my PR, and I rebase my PR now, please help trigger the check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants