fix: fix custom_ar bug for rocm #402
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
internal source has been updated, please review the changes! |
liaocz
force-pushed
the
hotfix/rocm_custom_ar
branch
from
28073ff to
303a32b
Compare
|
internal source has been updated, please review the changes! |
LLLLKKKK
requested changes
Dec 1, 2025
|
|
||
| // meta data buffers need to be "uncached" for signal on MI200 | ||
| meta_ = aiter::allocate_meta_buffer(aiter::meta_size() + comm_buf_threshold_); | ||
| buffer_ = torch::empty( |
Collaborator
Author
There was a problem hiding this comment.
使用GPU加载模型和开启custom_allreduce时产生的多tp精度问题，定位在初始化时使用torch分配的buffer存在被干扰的情况，所以使用hipmalloc进行管理，较大的dense模型和vl模型等均验证通过了；
smoke test也已经添加
liaocz
force-pushed
the
hotfix/rocm_custom_ar
branch
from
303a32b to
9a05005
Compare
|
internal source has been updated, please review the changes! |
1 similar comment
|
internal source has been updated, please review the changes! |
liaocz
force-pushed
the
hotfix/rocm_custom_ar
branch
from
9a05005 to
fc25079
Compare
|
internal source has been updated, please review the changes! |
1 similar comment
|
internal source has been updated, please review the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.