DO-1984: Reduce cost of node-pr workflow #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
This PR aims to make our
node-prworkflow cheaper to run on average.Previously we had split workflows into many jobs to make them run faster and be easier to digest and debug. However due to GitHub rounding up build minutes on jobs, this turned out to be quite expensive when multiple jobs would only run for 10 seconds or so.Therefore, I've combined testing, linting and formatting checks into one job. I've also removed the cleanup step and replaced it with a simple expiry after one day. This might cause issues in large repos so we'll have to see how it behaves. If it does, I can look back into using native caches (although this caused weird permission issues).
I've also split some of the shared logic into composite actions. I can see these potentially being useful across other workflows too so I think it makes sense to do this.
Toggl:
DO-1984: Code reviewNotes to reviewers
ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback