-
Notifications
You must be signed in to change notification settings - Fork 1
broadcom and pensando nic enhancements for networkplugin #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jaspals3123
wants to merge
8
commits into
development
Choose a base branch
from
jaspal_networkplugin_enhance
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,837
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandraBara
requested changes
Jan 7, 2026
alexandraBara
requested changes
Jan 8, 2026
Comment on lines
+1677
to
+1683
| # Log summary of collected and uncollected commands | ||
| if collected_commands: | ||
| self._log_event( | ||
| category=EventCategory.NETWORK, | ||
| description=f"Successfully collected {len(collected_commands)} nicctl commands: {', '.join(collected_commands)}", | ||
| priority=EventPriority.INFO, | ||
| ) |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think this is needed, i would just log the uncollected ones
alexandraBara
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
` CMD_NICCLI_LISTDEV = "niccli --list_devices"
CMD_NICCLI_GETQOS_TEMPLATE = "niccli --dev {device_num} qos --ets --show"
Run with :node-scraper run-plugins NetworkPlugin`Output:
(venv) (py39) jaspals@smci350-zts-gtu-f11-15:~/node-scraper$ node-scraper run-plugins NetworkPlugin 2026-01-07 15:58:05 UTC INFO nodescraper | Log path: ./scraper_logs_smci350_zts_gtu_f11_15_2026_01_07-03_58_05_PM 2026-01-07 15:58:05 UTC INFO nodescraper | System Name: smci350-zts-gtu-f11-15 2026-01-07 15:58:05 UTC INFO nodescraper | System SKU: None 2026-01-07 15:58:05 UTC INFO nodescraper | System Platform: None 2026-01-07 15:58:05 UTC INFO nodescraper | System location: SystemLocation.LOCAL 2026-01-07 15:58:05 UTC INFO nodescraper | Initializing connection manager for InBandConnectionManager with default args 2026-01-07 15:58:05 UTC INFO nodescraper | -------------------------------------------------- 2026-01-07 15:58:05 UTC INFO nodescraper | Running plugin NetworkPlugin 2026-01-07 15:58:05 UTC INFO nodescraper | Initializing connection: InBandConnectionManager 2026-01-07 15:58:05 UTC INFO nodescraper | Using local shell 2026-01-07 15:58:05 UTC INFO nodescraper | Checking OS family 2026-01-07 15:58:05 UTC INFO nodescraper | OS Family: LINUX 2026-01-07 15:58:05 UTC INFO nodescraper | Running data collector: NetworkCollector 2026-01-07 15:58:07 UTC INFO nodescraper | (NetworkPlugin) Collected network data: 18 interfaces, 3 routes, 3 rules, 3 neighbors, 18 ethtool entries, 0 Broadcom NICs, 8 Pensando NICs, 8 Pensando DCQCN entries, 8 Pensando environment entries, 8 Pensando PCIe ATS entries, 8 Pensando ports, 8 Pensando QoS entries, 8 Pensando RDMA statistics, Pensando host software version: Yes, 8 Pensando firmware versions 2026-01-07 15:58:07 UTC INFO nodescraper | Closing connections 2026-01-07 15:58:07 UTC INFO nodescraper | Running result collators 2026-01-07 15:58:07 UTC INFO nodescraper | Running TableSummary result collator 2026-01-07 15:58:07 UTC INFO nodescraper |