CIT: Modificar API y APP p/solicitud telemedicina #2162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanIRamirez
force-pushed
the
CIT-395
branch
from
5656f0a to
1c96518
Compare
9 tasks
negro89
reviewed
Dec 19, 2025
|
|
||
| if (!req.query.teleConsulta) { | ||
| const conceptosTurneables: any = await tipoPrestacion.find({ teleConsulta: true }); | ||
| const conceptId = []; |
Contributor
There was a problem hiding this comment.
Esta parte se podría resolver con un map y quedaría mas legible:
Suggested change
| const conceptId = []; | |
| const conceptIdArray = conceptosTurneables?.map(ct => ct.conceptId); | |
| query.where('tipoPrestaciones.conceptId').nin(conceptIdArray); |
Sugiero tambien renombrarlo "conceptIdArray" o algo similar, ya que "conceptId" es un atributo propio de todos los conceptos snomed
negro89
reviewed
Dec 19, 2025
Contributor
negro89
left a comment
negro89
left a comment
There was a problem hiding this comment.
Juancho, dejé algunas dudas y/u observaciones. Cualquier cosita consultame 👌🏼
| } | ||
|
|
||
| query.exec((err, data) => { | ||
| await query.exec((err, data) => { |
Contributor
There was a problem hiding this comment.
Acá si vamos a awaitear deberíamos eliminar callbacks (una u otra):
Suggested change
| await query.exec((err, data) => { | |
| try { | |
| const data = await query.exec(); | |
| res.json(data); | |
| } catch (err) { | |
| return next(err); | |
| } |
| const tipoPrestacion = Auth.getPermissions(req, 'visualizacionInformacion:dashboard:citas:tipoPrestacion:?'); | ||
| if (tipoPrestacion.length > 0 && tipoPrestacion[0] !== '*') { | ||
| permisos.tipoPrestacion = tipoPrestacion; | ||
| const tipo_Prestacion = Auth.getPermissions(req, 'visualizacionInformacion:dashboard:citas:tipoPrestacion:?'); |
Contributor
There was a problem hiding this comment.
Por qué el renombre de tipoPrestacion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requerimiento
https://proyectos.andes.gob.ar/browse/CIT-395
Funcionalidad desarrollada
UserStories llegó a completarse
Requiere actualizaciones en la base de datos