Adding net10.0 to the list of target frameworks#1640
Open
lipchev wants to merge 2 commits intoangularsen:masterfrom
Open
Adding net10.0 to the list of target frameworks#1640lipchev wants to merge 2 commits intoangularsen:masterfrom
lipchev wants to merge 2 commits intoangularsen:masterfrom
Conversation
Collaborator
lipchev
commented
Dec 7, 2025
lipchev
commented
- Adding net10.0 to the list of target frameworks
- updating all packages to their latest versions
- updating all packages to their latest versions
lipchev
commented
Dec 7, 2025
Comment on lines
+83
to
+84
| # TODO check if the extension for VS2022 is compatible it VS2026 | ||
| if($vsInstance.Contains('2026') -or $vsInstance.Contains('2022')) |
Collaborator
Author
There was a problem hiding this comment.
For the record, the local build doesn't throw any errors (when running the script as administrator) but I haven't tested if the resulting code is any different (normally it shouldn't, as we haven't changed anything about the nano-project itself).
lipchev
commented
Dec 7, 2025
Comment on lines
+31
to
+33
| <!-- Disable ILLink analyzers due to incompatibility with C# 14 extension members preview | ||
| "CSC : error AD0001: Analyzer 'ILLink.RoslynAnalyzer.DynamicallyAccessedMembersAnalyzer' threw an exception of type 'System.InvalidCastException' with message 'Unable to cast object of type 'Microsoft.CodeAnalysis.CSharp.Symbols.PublicModel.NonErrorNamedTypeSymbol' to type 'Microsoft.CodeAnalysis.IMethodSymbol'.'." --> | ||
| <IsAotCompatible>false</IsAotCompatible> | ||
| <!-- <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">true</IsAotCompatible> --> | ||
| <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net10.0'))">true</IsAotCompatible> |
Collaborator
Author
There was a problem hiding this comment.
I just realized that the persistence of this ILink.RoslyAnalyzer exception is likely related to this issue: dotnet/runtime#120728. That's a bit of a bummer, as if we wanted to use the extension features in any of the other projects (not just the extension properties) we'd be forced to push the AoT compatibility version to net10.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.