Skip to content

Conversation

@alexyaroshuk
Copy link
Contributor

What does this PR do?

Issue: The share button in session-header.tsx had a fixed width of w-[60px], causing it to not properly resize when the button text is longer (e.g., in different languages, such as Portuguese like in the before/after).

Changes Made:

Changed the share button's class prop from rounded-sm w-[60px] h-[24px] to rounded-sm h-[24px] px-3
This replaces the fixed width with horizontal padding, allowing the button to hug its content, while maintaining the original style.

Before

share-btn_BEFORE

After

share-btn_AFTER

Why it works:
Using px-3 instead of a fixed width allows the button to size itself based on the content (the localized text), making it responsive to different language lengths while maintaining consistent padding.

Files Changed:

packages/app/src/components/session/session-header.tsx:170 - Share button trigger props

How did you verify your code works?

Manual testing:

  1. made sure style is consistent with original style (px-3 achieves the same look)
  2. checked different screen widths

@github-actions
Copy link
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions
Copy link
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on my search, no duplicate PRs were found that address the same issue as PR #11371. The search returned the current PR itself and unrelated PRs about different components (sidebar accessibility, session popover button styles).

The only tangentially related result was PR #10554 about session popover button styling, but that addresses hover states for primary buttons in a different component, not the share button width/padding issue in the session header.

No duplicate PRs found

@adamdotdevin adamdotdevin merged commit ac254fb into anomalyco:dev Jan 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants