-
Notifications
You must be signed in to change notification settings - Fork 8.7k
fix(app): session header 'share' button to hug content #11371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, no duplicate PRs were found that address the same issue as PR #11371. The search returned the current PR itself and unrelated PRs about different components (sidebar accessibility, session popover button styles). The only tangentially related result was PR #10554 about session popover button styling, but that addresses hover states for primary buttons in a different component, not the share button width/padding issue in the session header. No duplicate PRs found |
What does this PR do?
Issue: The share button in session-header.tsx had a fixed width of w-[60px], causing it to not properly resize when the button text is longer (e.g., in different languages, such as Portuguese like in the before/after).
Changes Made:
Changed the share button's class prop from rounded-sm w-[60px] h-[24px] to rounded-sm h-[24px] px-3
This replaces the fixed width with horizontal padding, allowing the button to hug its content, while maintaining the original style.
Before
After
Why it works:
Using px-3 instead of a fixed width allows the button to size itself based on the content (the localized text), making it responsive to different language lengths while maintaining consistent padding.
Files Changed:
packages/app/src/components/session/session-header.tsx:170 - Share button trigger props
How did you verify your code works?
Manual testing: