fix(cli): skip local agent validation in attach mode#8154
Open
zerone0x wants to merge 1 commit intoanomalyco:devfrom
Open
fix(cli): skip local agent validation in attach mode#8154zerone0x wants to merge 1 commit intoanomalyco:devfrom
zerone0x wants to merge 1 commit intoanomalyco:devfrom
Conversation
When using `opencode run --attach` with the `--agent` flag, the CLI would crash with "No context found for instance" because Agent.get() requires the Instance context that is only available after bootstrap(). In attach mode, bootstrap() is never called since we're connecting to a remote server. This fix skips local agent validation in attach mode, allowing the remote server to handle agent validation instead. Fixes anomalyco#6489 anomalyco#8094 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6489 #8094
When using
opencode run --attach <server> --agent <agent>, the CLI crashes with:Problem
The
Agent.get()function requiresInstancecontext that is established bybootstrap(). In attach mode,bootstrap()is never called since we connect to a remote server. This causes the crash when trying to validate the agent locally.Solution
Skip local agent validation when in attach mode by adding an early return. The remote server handles agent validation instead.
What does this PR do?
Adds a check to skip local agent validation when the
--attachflag is used, allowing the remote server to handle agent validation.How did you verify your code works?
Reviewed the code logic and confirmed the fix aligns with the root cause analysis from #6489. The change is minimal and focused - it only adds an early return for the attach mode case.
🤖 Generated with Claude Code