fix(provider): add required field to object schemas for strict validators#8218
Open
zerone0x wants to merge 1 commit intoanomalyco:devfrom
Open
fix(provider): add required field to object schemas for strict validators#8218zerone0x wants to merge 1 commit intoanomalyco:devfrom
zerone0x wants to merge 1 commit intoanomalyco:devfrom
Conversation
…tors Backends like SGLang with strict JSON Schema validation fail when object schemas don't have a 'required' field. This fix ensures all object-type schemas have 'required' set (as an empty array if no fields are required). Fixes anomalyco#8184 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8184
Backends like SGLang with strict JSON Schema validation (using Pydantic) fail when object schemas don't have a
requiredfield, returning errors like:This PR ensures all object-type schemas have
requiredset (as an empty array[]if no fields are required).Changes
ensureRequiredField()helper inProviderTransform.schema()that recursively addsrequired: []to all object schemas that don't have itTest plan
🤖 Generated with Claude Code