✨ Upgrade sidepanel extension to JupyterLab 4.x compatibility#34495
✨ Upgrade sidepanel extension to JupyterLab 4.x compatibility#34495liferoad merged 16 commits intoapache:masterfrom
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Does this still work with 3.x? we will need to release this later as well. |
I build it with 3.x and it failed. Because the version of |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
left a comment
There was a problem hiding this comment.
Actually, looks like this is causing precommit failures, could you please take a look? https://github.com/apache/beam/actions/runs/14197749402/job/39777121469
|
Do not merge this PR. Please wait for me to LGTM. |
The testsuites and CI scripts are also needed to be upgrade. I'll commit my changes later this day. |
|
@nika-qubit can you share the steps to build a new release? I want to test this internally first. |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @liferoad for label python. Available commands:
|
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
|
|
Reminder, please take a look at this pr: @tvalentyn @damccorm |
|
R: @liferoad Stopping the bot to keep this sticky |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Updated all
@jupyterlab/*dependencies to v4.xAdapted to breaking API changes (SessionContext, TypeScript types, etc.)
Fixed strict type checking errors introduced in TS 4.x
Requires Node 16+ and updated dependencies
Upgrade to React 18+
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.