feat: pxf fdw support parallel scan #61
Open
+1,581
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fdw support pg parallel scan - add parallel scan correctness tests for PXF
ostinru
reviewed
Feb 11, 2026
| // Parallel mode: only process the specified fragment | ||
| Fragment specificFragment = fragmenterService.getFragmentByIndex( | ||
| context, context.getSpecificFragmentIndex()); | ||
| fragments = java.util.Collections.singletonList(specificFragment); |
Collaborator
There was a problem hiding this comment.
NIT: import java.util.Collections?
ostinru
reviewed
Feb 11, 2026
| slock_t mutex; /* mutex for accessing shared state */ | ||
| int total_fragments; /* total number of fragments */ | ||
| int next_fragment; /* next fragment index to be assigned */ | ||
| bool finished; /* true if all fragments have been processed */ |
Collaborator
There was a problem hiding this comment.
true if all fragments have been processed... or cancelled?
And. What is a purpose of write-only variable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#58
Change logs
Currently, parallel FDW is supported. This implementation depends on the kernel's commit.
apache/cloudberry#1571
Contributor's checklist
Here are some reminders before you submit your pull request: