Refactor Quota Summary API by julien-vaz · Pull Request #10505 · apache/cloudstack

julien-vaz · 2025-03-05T13:42:16Z

Description

The quotaSummary API has abstract behaviors and codes, as well as return values not aligned with its purposes. Furthermore, when the account is a project, no information is returned.

Also, in the UI, when opening the Quota Summary details for accounts who owned removed domains, the CloudStack launches an error to the user.

Therefore, this PR:

improves the API's behavior and return values;
adds information for project accounts (through parameter listall=true);
adds information for accounts/domains which have been already removed and a filter for accounts in the UI;

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

How Has This Been Tested?

On CloudMonkey I called quotaSummary API and checked the return value:

only relevant information about the summaries is being displayed;
accounts and domains which have been removed are especified in the summary;
project accounts are also being considered by the API.

On the UI, the filter for removed accounts is working properly.

julien-vaz · 2025-03-05T13:50:09Z

@blueorangutan package

blueorangutan · 2025-03-05T13:52:04Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-05T14:12:33Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12665

codecov · 2025-03-05T21:05:53Z

Codecov Report

❌ Patch coverage is 6.86695% with 217 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.88%. Comparing base (a5b6bc3) to head (592f1cb).
⚠️ Report is 13 commits behind head on main.

Files with missing lines	Patch %	Lines
...udstack/api/response/QuotaResponseBuilderImpl.java	19.17%	58 Missing and 1 partial ⚠️
...org/apache/cloudstack/quota/vo/QuotaSummaryVO.java	0.00%	47 Missing ⚠️
...ache/cloudstack/quota/dao/QuotaSummaryDaoImpl.java	0.00%	28 Missing ⚠️
...c/main/java/com/cloud/user/AccountManagerImpl.java	0.00%	28 Missing ⚠️
.../cloudstack/api/response/QuotaSummaryResponse.java	0.00%	24 Missing ⚠️
...apache/cloudstack/api/command/QuotaSummaryCmd.java	9.52%	18 Missing and 1 partial ⚠️
...ache/cloudstack/quota/QuotaAccountStateFilter.java	0.00%	11 Missing ⚠️
.../main/java/com/cloud/domain/dao/DomainDaoImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #10505      +/-   ##
============================================
- Coverage     17.89%   17.88%   -0.01%     
+ Complexity    16092    16084       -8     
============================================
  Files          5936     5941       +5     
  Lines        532734   533013     +279     
  Branches      65165    65212      +47     
============================================
+ Hits          95347    95348       +1     
- Misses       426711   426989     +278     
  Partials      10676    10676

Flag	Coverage Δ
uitests	`3.67% <ø> (-0.01%)`	⬇️
unittests	`18.99% <6.86%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

julien-vaz · 2025-03-06T17:30:25Z

@blueorangutan package

blueorangutan · 2025-03-06T17:32:03Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-06T17:59:03Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12690

julien-vaz · 2025-03-11T15:45:34Z

I've just successfully builded the packages locally with -Dnoredist. Therefore, I'm requesting the package building again

julien-vaz · 2025-03-11T15:45:49Z

@blueorangutan package

blueorangutan · 2025-03-11T15:46:05Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-11T16:37:19Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12739

julien-vaz · 2025-03-11T17:05:44Z

@blueorangutan package

blueorangutan · 2025-03-11T17:08:03Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-11T18:22:04Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12743

plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaSummaryCmd.java

…/command/QuotaSummaryCmd.java Co-authored-by: Fabricio Duarte <[email protected]>

sureshanaparti · 2025-06-05T09:25:19Z

@blueorangutan package

blueorangutan · 2025-06-05T09:26:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

julien-vaz · 2025-09-02T17:34:29Z

@blueorangutan package

blueorangutan · 2025-09-02T17:36:04Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-02T18:00:22Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 14821

harikrishna-patnala · 2025-09-22T06:34:26Z

@julien-vaz There is still failure in the build, can you please fix it and suggest how far this PR is ready, has this been tested recently ?

nvazquez

Thanks @julien-vaz, some comments from my review

framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaAccountStateFilter.java

engine/schema/src/main/java/com/cloud/domain/dao/DomainDaoImpl.java

plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaSummaryCmd.java

plugins/database/quota/src/main/java/org/apache/cloudstack/quota/QuotaServiceImpl.java

github-actions · 2025-10-16T09:11:47Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

…ary-api

winterhazel · 2026-02-03T13:34:50Z

@blueorangutan package

blueorangutan · 2026-02-03T13:36:06Z

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-03T13:55:51Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16688

winterhazel · 2026-02-03T14:16:19Z

@blueorangutan package

blueorangutan · 2026-02-03T14:18:04Z

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-03T14:37:53Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16689

Refactor Quota Summary API

115d303

boring-cyborg bot added component:api component:quota labels Mar 5, 2025

winterhazel added this to the 4.21.0 milestone Mar 5, 2025

winterhazel self-requested a review March 6, 2025 13:06

Fixes imports

36fe76e

Fix QuotaServiceImplTest

6897eeb

winterhazel requested changes Apr 8, 2025

View reviewed changes

plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaSummaryCmd.java Outdated Show resolved Hide resolved

plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaSummaryCmd.java Outdated Show resolved Hide resolved

Update plugins/database/quota/src/main/java/org/apache/cloudstack/api…

87feb02

…/command/QuotaSummaryCmd.java Co-authored-by: Fabricio Duarte <[email protected]>

bernardodemarco self-requested a review June 4, 2025 17:39

Fix QuotaSummaryCmd

1dcfbbf

sureshanaparti added this to Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti requested a review from DaanHoogland June 5, 2025 09:25

nvazquez reviewed Oct 1, 2025

View reviewed changes

RosiKyu assigned RosiKyu and unassigned RosiKyu Oct 13, 2025

github-actions bot added the status:has-conflicts label Oct 16, 2025

harikrishna-patnala modified the milestones: 4.22.0, 4.22.1 Nov 12, 2025

harikrishna-patnala removed this from Apache CloudStack 4.22.0 Nov 12, 2025

winterhazel modified the milestones: 4.22.1, 4.23.0 Dec 20, 2025

winterhazel self-assigned this Feb 3, 2026

Merge remote-tracking branch 'upstream/main' into refactor-quota-summ…

589a07e

…ary-api

github-actions bot removed the status:has-conflicts label Feb 3, 2026

Apply suggestions + some adjustments

fc92e39

Remove duplicated check

b532758

Fix checkstyle

c90b609

boring-cyborg bot added the component:networking label Feb 3, 2026

winterhazel added 2 commits February 4, 2026 08:41

Adjust entity owner

a146047

Remove unused method + fix tests

592f1cb

winterhazel self-requested a review February 11, 2026 20:56

Conversation

julien-vaz commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

How Has This Been Tested?

Uh oh!

julien-vaz commented Mar 5, 2025

Uh oh!

blueorangutan commented Mar 5, 2025

Uh oh!

blueorangutan commented Mar 5, 2025

Uh oh!

codecov bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

julien-vaz commented Mar 6, 2025

Uh oh!

blueorangutan commented Mar 6, 2025

Uh oh!

blueorangutan commented Mar 6, 2025

Uh oh!

julien-vaz commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

julien-vaz commented Mar 11, 2025

Uh oh!

blueorangutan commented Mar 11, 2025

Uh oh!

blueorangutan commented Mar 11, 2025

Uh oh!

julien-vaz commented Mar 11, 2025

Uh oh!

blueorangutan commented Mar 11, 2025

Uh oh!

blueorangutan commented Mar 11, 2025

Uh oh!

Uh oh!

Uh oh!

sureshanaparti commented Jun 5, 2025

Uh oh!

blueorangutan commented Jun 5, 2025

Uh oh!

julien-vaz commented Sep 2, 2025

Uh oh!

blueorangutan commented Sep 2, 2025

Uh oh!

blueorangutan commented Sep 2, 2025

Uh oh!

harikrishna-patnala commented Sep 22, 2025

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

winterhazel commented Feb 3, 2026

Uh oh!

blueorangutan commented Feb 3, 2026

Uh oh!

blueorangutan commented Feb 3, 2026

Uh oh!

winterhazel commented Feb 3, 2026

Uh oh!

blueorangutan commented Feb 3, 2026

Uh oh!

blueorangutan commented Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

julien-vaz commented Mar 5, 2025 •

edited

Loading

codecov bot commented Mar 5, 2025 •

edited

Loading

julien-vaz commented Mar 11, 2025 •

edited

Loading