chore: Add Iceberg TPC-H benchmarking scripts #3294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add scripts to benchmark TPC-H queries against Iceberg tables using Comet's native iceberg-rust integration: - create-iceberg-tpch.py: Convert Parquet TPC-H data to Iceberg tables - tpcbench-iceberg.py: Run TPC-H queries against Iceberg catalog tables - comet-tpch-iceberg.sh: Shell script to run the benchmark with Comet Also updates README.md with Iceberg benchmarking documentation. Co-Authored-By: Claude Opus 4.5 <[email protected]>
andygrove
changed the title
…h.py Merge tpcbench-iceberg.py into tpcbench.py using mutually exclusive args: - --data for Parquet files - --catalog/--database for Iceberg tables Co-Authored-By: Claude Opus 4.5 <[email protected]>
andygrove
changed the title
Member
Author
|
@mbutrovich I can now run TPC-H w/ Iceberg native scan locally |
Resolve conflict in tpcbench.py by combining: - Upstream: --format and --options for multiple file formats - Branch: --catalog and --database for Iceberg tables Co-Authored-By: Claude Opus 4.5 <[email protected]>
mbutrovich
reviewed
Jan 27, 2026
dev/benchmarks/README.md
Outdated
|
|
||
| $SPARK_HOME/bin/spark-submit \ | ||
| --master $SPARK_MASTER \ | ||
| --jars $ICEBERG_JAR \ |
Contributor
There was a problem hiding this comment.
It should work either way, but this doesn't match the usage in create-iceberg-tpch.py. There we use --packages, here we're defining the jar. Both should work, I think, but maybe best to be consistent.
mbutrovich
reviewed
Jan 27, 2026
dev/benchmarks/README.md
Outdated
| --conf spark.cores.max=8 \ | ||
| --conf spark.executor.memory=16g \ | ||
| --conf spark.sql.catalog.local=org.apache.iceberg.spark.SparkCatalog \ | ||
| --conf spark.sql.catalog.local.type=hadoop \ |
Contributor
There was a problem hiding this comment.
This hardcodes the catalog. Above you have ICEBERG_CATALOG=${ICEBERG_CATALOG:-local}. I'd be consistent.
mbutrovich
reviewed
Jan 27, 2026
dev/benchmarks/README.md
Outdated
| --conf spark.sql.catalog.local.warehouse=$ICEBERG_WAREHOUSE \ | ||
| create-iceberg-tpch.py \ | ||
| --parquet-path $TPCH_DATA \ | ||
| --catalog local \ |
Contributor
There was a problem hiding this comment.
Same hardcoded catalog.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3294 +/- ##
============================================
+ Coverage 56.12% 59.95% +3.82%
- Complexity 976 1473 +497
============================================
Files 119 175 +56
Lines 11743 16167 +4424
Branches 2251 2682 +431
============================================
+ Hits 6591 9693 +3102
- Misses 4012 5126 +1114
- Partials 1140 1348 +208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Use --packages instead of --jars for table creation to match create-iceberg-tpch.py usage - Use $ICEBERG_CATALOG variable instead of hardcoding 'local' in spark.sql.catalog config to be consistent with comet-tpch-iceberg.sh - Clarify that JAR download is only needed for benchmark execution Co-Authored-By: Claude Opus 4.5 <[email protected]>
Member
Author
|
Thanks @mbutrovich! I pushed a commit to address the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
create-iceberg-tpch.py: Convert Parquet TPC-H data to Iceberg tablestpcbench-iceberg.py: Run TPC-H queries against Iceberg catalog tablescomet-tpch-iceberg.sh: Shell script to run the benchmark with CometTest plan
create-iceberg-tpch.pyto create Iceberg tables from Parquet datacomet-tpch-iceberg.shand verifyCometIcebergNativeScanExecappears in plans🤖 Generated with Claude Code