feat: [iceberg] Test Parquet metadata caching in iceberg-rust #3365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oned columns) and run a representative test.
…er assertion in DPP test.
1. findAllIcebergSplitData() collected perPartitionByLocation (all partitions' data) 2. This map was captured in the createCometExecIter closure 3. ZippedPartitionsRDD serialized that closure to every task 4. Each task received ALL partitions' data (925 bytes to both tasks) Instead we now use CometIcebergSplitRDD which puts per-partition data in Partition objects.
…hat every partition doesn't come over.
… columns), fixes TestRuntimeFiltering Iceberg Java tests with column renames. CometIcebergSplitRDD registers subqueries so native code can look them up, fixes TestViews Iceberg Java tests with rewritten filter.
… assertion at index lookup, and defensive fallback if future Spark behavior changes.
# Conflicts: # .github/workflows/iceberg_spark_test.yml
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3365 +/- ##
============================================
+ Coverage 56.12% 60.17% +4.05%
- Complexity 976 1502 +526
============================================
Files 119 174 +55
Lines 11743 16348 +4605
Branches 2251 2713 +462
============================================
+ Hits 6591 9838 +3247
- Misses 4012 5129 +1117
- Partials 1140 1381 +241 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A.
Rationale for this change
apache/iceberg-rust#2100 adds Parquet metadata caching to iceberg-rust's
ArrowReader. We want to test that in Comet CI. Note that this builds on top of #3349's changes and should not be merged.What changes are included in this PR?
Point iceberg-rust dependency at feature branch for apache/iceberg-rust#2100 and run
cargo update.How are these changes tested?
Existing tests.