DRILL-7714: Build DrillClient as a static archive#2064
Open
j-sidharth wants to merge 1 commit intoapache:masterfrom
Open
DRILL-7714: Build DrillClient as a static archive#2064j-sidharth wants to merge 1 commit intoapache:masterfrom
j-sidharth wants to merge 1 commit intoapache:masterfrom
Conversation
sanel
reviewed
May 23, 2020
sanel
left a comment
sanel
left a comment
There was a problem hiding this comment.
Looks OK, but why you haven't used ADD_LIBRARY & STATIC arg?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRILL-7714: Build DrillClient as a static archive
Description
(Please describe the change. If more than one ticket is fixed, include a reference to those tickets.)
Documentation
(Please describe user-visible changes similar to what should appear in the Drill documentation.)
Testing
(Please describe how this PR has been tested.)