MINIFICPP-2703 Update GCP extension to use unified credentials#2086
Open
lordgamez wants to merge 1 commit intoapache:mainfrom
Open
MINIFICPP-2703 Update GCP extension to use unified credentials#2086lordgamez wants to merge 1 commit intoapache:mainfrom
lordgamez wants to merge 1 commit intoapache:mainfrom
Conversation
szaszm
reviewed
Jan 12, 2026
Member
szaszm
left a comment
szaszm
left a comment
There was a problem hiding this comment.
Is this a behavior change that users need to be aware of?
Contributor
Author
From what I gathered there shouldn't be changes in the behavior of the GCP processors. The only change I saw is that when default credentials are used we cannot check them if they are valid in schedule time, so if they are invalid it will only be realized in processor trigger time. |
szaszm
approved these changes
Jan 14, 2026
fgerlits
reviewed
Jan 19, 2026
| return nullptr; | ||
| } | ||
| return *json_path_credentials; | ||
| return google::cloud::MakeServiceAccountCredentials(utils::file::get_content(*json_path)); |
Contributor
There was a problem hiding this comment.
I think it would be useful to check if the file exists, so the user gets a different error when they have mistyped the file name and when the file is empty.
martinzink
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/projects/MINIFICPP/issues/MINIFICPP-2703
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.