Handle null in ColumnExecutionNode #17434
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17434 +/- ##
============================================
+ Coverage 63.28% 63.35% +0.06%
Complexity 1474 1474
============================================
Files 3154 3155 +1
Lines 188007 188119 +112
Branches 28782 28793 +11
============================================
+ Hits 118984 119185 +201
+ Misses 59801 59716 -85
+ Partials 9222 9218 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
This is not required as it can be enabled via configuring _skipDefaultNullValues in Pinot segment record reader |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinot segment stores the default value for nulls. Thus the GenericRow returned by PinotSegmentRecordReader returns the default value in row.getValue(column).
This leads to an issue when a transformer expression requires such a column because the transform expression is evaluated on the default value.
eg:
concat(source_column, '_SUFFIX', '')results in null_SUFFIX rather than nullThis PR fixes that
Tags -
bugfix,backward-incompat