Skip to content

Add UI dashboard for Ruby runtime metrics #13373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wu-sheng merged 8 commits into from
Jul 20, 2025
Merged

Add UI dashboard for Ruby runtime metrics #13373

wu-sheng merged 8 commits into from
Jul 20, 2025

Conversation

@CodePrometheus
Copy link
Contributor

@CodePrometheus CodePrometheus commented Jul 17, 2025 •
edited
Loading

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

Ref apache/skywalking-ruby#7

ruby3

@CodePrometheus CodePrometheus added this to the 10.3.0 milestone Jul 17, 2025
@CodePrometheus CodePrometheus requested a review from wu-sheng July 17, 2025 05:13
@CodePrometheus CodePrometheus added submodule update Change submodule commit ID, including network protocol, query GraphQL and UI ruby Ruby agent related labels Jul 17, 2025
@CodePrometheus CodePrometheus changed the title Add ruby runtime Add UI dashboard for Ruby runtime metrics Jul 17, 2025
@wu-sheng
Copy link
Member

wu-sheng commented Jul 17, 2025

Could you add screenshots for these pages?

@wu-sheng wu-sheng requested a review from wankai123 July 17, 2025 05:44
@wu-sheng wu-sheng added the UI UI and front end related. label Jul 17, 2025
@wu-sheng
Copy link
Member

wu-sheng commented Jul 17, 2025

I think UI submodule update is a mistake? Please recheck.

@wu-sheng
Copy link
Member

wu-sheng commented Jul 17, 2025

UI has been updated through another PR.

@CodePrometheus CodePrometheus marked this pull request as draft July 18, 2025 00:29
@wu-sheng
Copy link
Member

wu-sheng commented Jul 18, 2025

Could you add ruby agent here?

@CodePrometheus
Copy link
Contributor Author

CodePrometheus commented Jul 18, 2025

Could you add ruby agent here?

Updated.

@CodePrometheus CodePrometheus marked this pull request as ready for review July 18, 2025 22:55
@CodePrometheus CodePrometheus requested a review from wankai123 July 19, 2025 06:42
wankai123
wankai123 approved these changes Jul 20, 2025
View reviewed changes
Copy link
Member

@wankai123 wankai123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit 8a61edd into apache:master Jul 20, 2025
510 of 514 checks passed
@CodePrometheus CodePrometheus deleted the add-ruby-runtime branch July 20, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wankai123 wankai123 wankai123 approved these changes

@wu-sheng wu-sheng Awaiting requested review from wu-sheng

Assignees

No one assigned

Labels

ruby Ruby agent related submodule update Change submodule commit ID, including network protocol, query GraphQL and UI UI UI and front end related.

Projects

None yet

Milestone

10.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@CodePrometheus @wu-sheng @wankai123