Merged
Conversation
bneradt
force-pushed
the
add_bt_to_crash_log
branch
from
684f8ec to
99e6175
Compare
bneradt
commented
Jan 5, 2026
Contributor
Author
There was a problem hiding this comment.
@cmcfarlen suggests looking into just doing the bt of the crashing thread instead of all.
Update:
After some thinking and discussion with Chris, we decided that a better path forward was to start the list of backtraces with the crashing thread's backtrace, label it and such, and include the others in case it is helpful for deadlock investigation (a crash can be triggered with a SIGSEGV from a kill command). That change has now been made.
bneradt
force-pushed
the
add_bt_to_crash_log
branch
5 times, most recently
from
f16a797 to
bc074d5
Compare
Send crash information from the signal handler to traffic_crashlog and record it in crash logs. This also: * Adds a 10-second timeout around backtrace collection to prevent the crashlog helper from hanging indefinitely if ptrace/waitpid blocks. This addresses a TODO comment that has been in the code for a while. * Removes the "Memory Regions" section from the crash logs. These are very rarely useful and otherwise add significant noise to the crash log. A post mordem gdb section on a core should be able to get this information if it is necessary in a particular instance.
bneradt
force-pushed
the
add_bt_to_crash_log
branch
from
bc074d5 to
383bdae
Compare
brbzull0
approved these changes
Jan 9, 2026
Contributor
brbzull0
left a comment
brbzull0
left a comment
There was a problem hiding this comment.
Looks good. Make sense the change about the crasahing thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send crash information from the signal handler to traffic_crashlog and
record it in crash logs.
This also:
crashlog helper from hanging indefinitely if ptrace/waitpid blocks.
This addresses a TODO comment that has been in the code for a while.
very rarely useful and otherwise add significant noise to the crash
log. A post mordem gdb section on a core should be able to get this
information if it is necessary in a particular instance.