Closed
Conversation
Zero-initialize buffers that are written to disk to avoid Valgrind
reporting uninitialized bytes in write syscalls.
Stripe::_init_directory: The raw_dir buffer is allocated but not
initialized before being written to disk during cache sync operations.
LogBuffer: The buffer uses alignment for the header which can leave
uninitialized padding bytes between header strings and the data section.
test_RamCache: IOBufferData allocations were not initialized. When the
freelist recycles this memory for cache writes, Valgrind reported
uninitialized bytes in the pwrite syscall.
Valgrind reports fixed:
1. Stripe directory write:
Syscall param pwrite64(buf) points to uninitialised byte(s)
at AIOThreadInfo::aio_thread_main(AIOThreadInfo*)
by Stripe::Stripe(CacheDisk*, long, long, int, int)
2. LogBuffer flush:
Syscall param write(buf) points to uninitialised byte(s)
at Log::flush_thread_main(void*)
by LogBuffer::LogBuffer(LogConfig const*, LogObject*, ...)
3. Cache write from recycled RamCache buffers:
Syscall param pwrite64(buf) points to uninitialised byte(s)
at AIOThreadInfo::aio_thread_main(AIOThreadInfo*)
Uninitialised value was created by a heap allocation
at IOBufferData::alloc(long, AllocType)
by test_RamCache(...)
bneradt
force-pushed
the
fix_crashing_stripe_test
branch
from
d658b8a to
a28fdf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.