Skip to content

hrw4u: Allows bulk compilation of many files (faster)#12865

Merged
zwoop merged 2 commits intoapache:masterfrom
zwoop:HRW4UBulkCompile
Feb 16, 2026
Merged

hrw4u: Allows bulk compilation of many files (faster)#12865
zwoop merged 2 commits intoapache:masterfrom
zwoop:HRW4UBulkCompile

Conversation

@zwoop
Copy link
Contributor

@zwoop zwoop commented Feb 6, 2026

No major changes here, just a way to rescript input:output pairs for bulk loading, since Python is slow at startup.

@zwoop zwoop added this to the 10.2.0 milestone Feb 6, 2026
@zwoop zwoop self-assigned this Feb 6, 2026
@zwoop zwoop added the hrw4u label Feb 6, 2026
@zwoop zwoop requested a review from Copilot February 6, 2026 22:59
@zwoop zwoop requested a review from mlibbey February 6, 2026 23:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a shared CLI entrypoint for hrw4u/u4wrh that supports compiling many files in a single Python invocation, including a bulk input:output pair mode, and documents the new usage.

Changes:

  • Introduce run_main() in tools/hrw4u/src/common.py to handle single-file, multi-file, and input:output bulk compilation flows.
  • Update scripts/hrw4u and scripts/u4wrh to use run_main() instead of duplicating CLI parsing logic.
  • Document bulk compilation usage; add a test utility helper for bulk runs.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tools/hrw4u/tests/utils.py Adds run_bulk_test() helper to validate bulk input:output compilation via subprocess.
tools/hrw4u/src/common.py Adds run_main() implementing bulk compilation/multi-file CLI behavior shared by hrw4u and u4wrh.
tools/hrw4u/scripts/u4wrh Switches script entrypoint to run_main().
tools/hrw4u/scripts/hrw4u Switches script entrypoint to run_main().
doc/admin-guide/configuration/hrw4u.en.rst Updates documentation with basic, multi-file, and bulk input:output usage examples.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zwoop
Copy link
Contributor Author

zwoop commented Feb 6, 2026

I addressed CoPilot's suggestions.

@bneradt
Copy link
Contributor

bneradt commented Feb 10, 2026

To address the rocky asan use after free failure in NetAccept, I'm doing a second attempt at an earlier fix which I had to back out: #12874

In the meantime, I'll re-run your CI jobs.

@zwoop zwoop merged commit 0fb268b into apache:master Feb 16, 2026
15 checks passed
@zwoop zwoop deleted the HRW4UBulkCompile branch February 16, 2026 17:20
@github-project-automation github-project-automation bot moved this to For v10.2.0 in ATS v10.2.x Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: For v10.2.0

Development

Successfully merging this pull request may close these issues.

2 participants