Annotate UIKit-bound controllers with @MainActor for Swift 6 #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xopoko
force-pushed
the
swift-6.2-mainactor
branch
from
4516172 to
2cf595b
Compare
Contributor
|
Hey @Xopoko thank you for the MR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@MainActorSWIFT_STRICT_CONCURRENCY=completebuilds by allowing constraint updates and animator callbacks on the main actorDetails
Building with Swift 6.2 and
SWIFT_SUPPRESS_WARNINGS=NOcurrently fails due to main-actor isolation violations in:UIViewController+Children.swift(helper methods used by container)HeightContraintOverlayTranslationController.swift(mutatesNSLayoutConstraint)InterruptibleAnimatorOverlayContainerTransitionCoordinator.swift(animator callbacks)Adding
@MainActorto these types brings them in line with UIKit’s main-thread requirement and resolves the concurrency errors. Behavior is unchanged; only actor isolation is specified explicitly.Tested: builds cleanly on Swift 6.2 simulator with strict concurrency.