Skip to content

feat: added setPageNumber function for Table v2 widget #41421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomjose92 wants to merge 5 commits into
base: release
Choose a base branch
from
Open

feat: added setPageNumber function for Table v2 widget #41421

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3edb7cc
Added setPageNumber function for Table v2 widget.
tomjose92 Nov 26, 2025
8ae3663
Updated test cases for Table widget to include for setPageNumber.
tomjose92 Nov 26, 2025
695443a
Added validation for the pageNo property in contentConfig since a set…
tomjose92 Nov 26, 2025
8c11eee
Added natural: true in the validations for pageNo so that its enforce…
tomjose92 Nov 27, 2025
d52ab88
Allowed changing page number from server side pagination enabled tabl…
tomjose92 Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/client/src/entities/DataTree/dataTreeWidget.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,10 @@ describe("generateDataTreeWidget", () => {
type: "array",
disabled: "return !options.entity.multiRowSelection",
},
setPageNumber: {
path: "pageNo",
type: "number",
},
setData: {
path: "tableData",
type: "array",
Expand Down Expand Up @@ -597,6 +601,10 @@ describe("generateDataTreeWidget", () => {
type: "array",
disabled: "return !options.entity.multiRowSelection",
},
setPageNumber: {
path: "Table1.pageNo",
type: "number",
},
setData: {
path: "Table1.tableData",
type: "array",
Expand Down
4 changes: 4 additions & 0 deletions app/client/src/widgets/TableWidgetV2/widget/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,10 @@ class TableWidgetV2 extends BaseWidget<TableWidgetProps, WidgetState> {
type: "array",
disabled: "return !options.entity.multiRowSelection",
},
setPageNumber: {
path: "pageNo",
type: "number",
},
setData: {
path: "tableData",
type: "array",
Expand Down
4 changes: 4 additions & 0 deletions app/client/src/widgets/wds/WDSTableWidget/config/settersConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ export const settersConfig = {
type: "array",
disabled: "return !options.entity.multiRowSelection",
},
setPageNumber: {
path: "pageNo",
type: "number",
},
setData: {
path: "tableData",
type: "array",
Expand Down
6 changes: 6 additions & 0 deletions app/client/src/workers/Evaluation/__tests__/setters.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ describe("Setter class test", () => {
expect(setters.getMap()).toEqual({
Table1: {
setData: true,
setPageNumber: true,
setSelectedRowIndex: true,
setVisibility: true,
},
Expand All @@ -88,11 +89,16 @@ describe("Setter class test", () => {
expect(Object.keys(methodMap)).toEqual([
"setVisibility",
"setSelectedRowIndex",
"setPageNumber",
"setData",
]);

globalContext.Table1.setVisibility(true);

expect(globalContext.Table1.isVisible).toEqual(true);

globalContext.Table1.setPageNumber(2);

expect(globalContext.Table1.pageNo).toEqual(2);
});
});
Loading