Fix: view shifts when editing spreadsheet #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ItzNotABug merged 1 commit into main from fix-dat-965

Dec 31, 2025

Member

ItzNotABug commented Dec 31, 2025 •

edited by coderabbitai bot

Loading

What does this PR do?

Fixes - #2689

Fixed via not invalidating the dependency. Update the row in place instead!

Test Plan

Manual.

Related PRs and Issues

N/A.

Have you read the Contributing Guidelines on issues?

Yes.

Summary by CodeRabbit

Refactor
- Enhanced row update mechanism in the database spreadsheet view to ensure immediate and consistent UI updates when modifying table data, replacing the previous external cache invalidation approach with direct in-component state updates.

_{✏️ Tip: You can customize this high-level summary in your review settings.}


          fix: don't invalidate and lose the spreadsheet state. update in place…

5a9cdfc

… instead!

ItzNotABug self-assigned this

appwrite bot commented Dec 31, 2025 •

edited

Loading

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)

Site	Status	Logs	Preview	QR
console-stage `688b7cf6003b1842c9dc`	Ready	View Logs	Preview URL

Tip

Environment variable changes require redeployment to take effect

Contributor

coderabbitai bot commented Dec 31, 2025 •

edited

Loading

Walkthrough

The changes modify the row update flow in a spreadsheet component and adjust related type definitions. A direct cache invalidation call for rows is removed and replaced with an inline state update mechanism: the row update handler now wraps the existing update function in an async callback that awaits the update result, then directly updates the paginated rows store on success before returning the result. Additionally, the paginatedRows store type parameter is broadened to accept either Models.DefaultRow or Models.Row, enabling support for both row types in the sparse paged data store.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix: view shifts when editing spreadsheet' directly reflects the main objective of the PR, which is to prevent view shifting when editing a spreadsheet by implementing in-place row updates instead of invalidating dependencies.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d056d35 and 5a9cdfc.

📒 Files selected for processing (2)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte
src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/store.ts

🧰 Additional context used

📓 Path-based instructions (6)

**/*.{ts,tsx,js,jsx,svelte}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,js,jsx,svelte}: Import reusable modules from the src/lib directory using the $lib alias
Use minimal comments in code; reserve comments for TODOs or complex logic explanations
Use $lib, $routes, and $themes aliases instead of relative paths for module imports

Files:

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/store.ts
src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte

**/*.ts

📄 CodeRabbit inference engine (AGENTS.md)

**/*.ts: Define types inline or in .d.ts files, avoid creating separate .types.ts files
Use TypeScript in non-strict mode; any type is tolerated in this project

Files:

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/store.ts

**/*.{ts,tsx,js,jsx,svelte,json}

📄 CodeRabbit inference engine (AGENTS.md)

Use 4 spaces for indentation, single quotes, 100 character line width, and no trailing commas per Prettier configuration

Files:

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/store.ts
src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte

src/routes/**

📄 CodeRabbit inference engine (AGENTS.md)

Configure dynamic routes using SvelteKit convention with [param] syntax in route directory names

Files:

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/store.ts
src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte

src/routes/**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use SvelteKit file conventions: +page.svelte for components, +page.ts for data loaders, +layout.svelte for wrappers, +error.svelte for error handling, and dynamic route params in square brackets like [param]

Files:

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte

**/*.svelte

📄 CodeRabbit inference engine (AGENTS.md)

Use Svelte 5 + SvelteKit 2 syntax with TypeScript for component development

Files:

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte

🧠 Learnings (3)

📚 Learning: 2025-10-07T14:17:11.597Z

Learnt from: ItzNotABug
Repo: appwrite/console PR: 2413
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/(entity)/helpers/terminology.ts:28-28
Timestamp: 2025-10-07T14:17:11.597Z
Learning: In src/routes/(console)/project-[region]-[project]/databases/database-[database]/(entity)/helpers/terminology.ts, the empty `vectordb: {}` entry in baseTerminology is intentional. The vectordb database type is not currently used because the backend API is not finalized, and no database type returns 'vectordb' at the moment.

Applied to files:

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/store.ts

📚 Learning: 2025-09-25T04:21:57.071Z

Learnt from: ItzNotABug
Repo: appwrite/console PR: 2373
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte:536-552
Timestamp: 2025-09-25T04:21:57.071Z
Learning: In the Appwrite console database suggestions flow, after successfully creating columns via `createColumns()`, the `await invalidate(Dependencies.TABLE)` call causes the view to be destroyed and another view (populated table view) to be rendered, automatically cleaning up component state without needing manual reset.

Applied to files:

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte

📚 Learning: 2025-09-30T07:41:06.679Z

Learnt from: ItzNotABug
Repo: appwrite/console PR: 2425
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte:454-468
Timestamp: 2025-09-30T07:41:06.679Z
Learning: In `src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte`, the column suggestions API (console.suggestColumns) has a maximum limit of 7 columns returned, which aligns with the initial placeholder count of 7 in customColumns.

Applied to files:

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte

🧬 Code graph analysis (1)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/store.ts (1)

src/lib/constants.ts (1)

SPREADSHEET_PAGE_LIMIT (2-2)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: build
GitHub Check: e2e

🔇 Additional comments (2)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte (1)

1107-1114: In-place update approach effectively prevents view shift.

The async wrapper correctly awaits the update operation and only modifies local state on success. This aligns well with the PR objective to avoid invalidation-triggered view shifts.

One minor observation: updateRowContents returns a boolean rather than the updated row from the server (lines 623-647). This means any server-side transformations (e.g., auto-updated timestamps, computed fields) won't be immediately reflected in the local spreadsheet state until the next data refresh. This is likely acceptable for this use case, but worth noting.

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/store.ts (1)

196-198: Verify type compatibility between Models.DefaultRow and Models.Row.

The broadened type union enables in-place row updates, which aligns with the PR objective. However, ensure that Models.DefaultRow and Models.Row are structurally compatible and that this change doesn't introduce type mismatches in other parts of the codebase that consume paginatedRows.

Both type definitions are from the external @appwrite.io/console SDK package and cannot be inspected in the repository. Review the SDK package documentation or type definitions to confirm structural compatibility.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

ChiragAgg5k approved these changes

View reviewed changes

ItzNotABug merged commit 936666d into main

4 checks passed

ItzNotABug deleted the fix-dat-965 branch

December 31, 2025 15:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet