Conversation
| import typescript from "rollup-plugin-typescript"; | ||
| import pkg from "./package.json"; | ||
|
|
||
| export default [ |
There was a problem hiding this comment.
'export' is only available in ES6 (use 'esversion: 6').
| import resolve from "rollup-plugin-node-resolve"; | ||
| import commonjs from "rollup-plugin-commonjs"; | ||
| import typescript from "rollup-plugin-typescript"; | ||
| import pkg from "./package.json"; |
There was a problem hiding this comment.
'import' is only available in ES6 (use 'esversion: 6').
| @@ -0,0 +1,20 @@ | |||
| import resolve from "rollup-plugin-node-resolve"; | |||
| import commonjs from "rollup-plugin-commonjs"; | |||
| import typescript from "rollup-plugin-typescript"; | |||
There was a problem hiding this comment.
'import' is only available in ES6 (use 'esversion: 6').
| @@ -0,0 +1,20 @@ | |||
| import resolve from "rollup-plugin-node-resolve"; | |||
| import commonjs from "rollup-plugin-commonjs"; | |||
There was a problem hiding this comment.
'import' is only available in ES6 (use 'esversion: 6').
| @@ -0,0 +1,20 @@ | |||
| import resolve from "rollup-plugin-node-resolve"; | |||
There was a problem hiding this comment.
'import' is only available in ES6 (use 'esversion: 6').
|
One thing to note is that you can add typescript definitions to a project without having to re-write everything. https://www.typescriptlang.org/docs/handbook/declaration-files/introduction.html Not useful now, but probably good to know for the future. |
| "name": "orcajs", | ||
| "version": "1.1.4", | ||
| "main": "./dist/orca.js", | ||
| "version": "1.1.5", |
There was a problem hiding this comment.
Your branch and PR is 2.0.0
Do you want to bump the major version? If there are breaking API changes, we definitely should. If the API has changed and the only definition are typescript definitions, then a minor bump seems OK.
4 participants
This is a complete overhaul of Orca to be written in Typescript and bundled with Rollup for cjs, esm, and umd formats. It also does a number of small things to simplify the code, normalize naming, and expand spec coverage.