get_many() no longer returns missing documents#82
Merged
apetenchea merged 3 commits intomainfrom Feb 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_many()was in a weird state:See #81
I think the best decision is to follow the docs and maintain compatibility with the old python-arango.
For that, I had to change the contract of
get_many()and make it returnResult[Jsons], meaning it can no longer return "Any" type (which would make filtering impossible).Note
Medium Risk
Behavioral/contract change to
get_many()can break callers relying on error entries or 1:1 input/output alignment; other changes are low-risk dependency and typing/tooling updates.Overview
Changes
Collection.get_many()to stop returning per-document error entries for missing/revision-mismatched documents. It now filters the API response to only include successful documents (those with_id) and tightens the return type toResult[Jsons]; tests are updated to expect shorter results instead of trailingerrorobjects.Bumps package/tooling versions and typing config:
__version__to1.1.0,pyjwtminimum to2.10.0, mypy to1.15.0(pre-commit and dev deps), and disablesmypy’swarn_unused_ignores; adds a targeted# type: ignore[arg-type]forjwt.decodeoptions.Written by Cursor Bugbot for commit 2e41350. This will update automatically on new commits. Configure here.