Adding schema validation #387
Merged
+24
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| data["waitForSync"] = sync | ||
| if schema is not None: | ||
| if not isinstance(schema, dict) or len(schema) == 0: | ||
| raise ValueError("schema parameter must be a non-empty dict") |
There was a problem hiding this comment.
Schema removal from collections no longer possible
Medium Severity
The validation rejecting empty dicts removes the previously documented way to clear schema validation from a collection (configure(schema={})). Since schema=None means "don't change," and schema={} now raises ValueError, there's no way for users to remove an existing schema. This is a functional regression with no alternative provided.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #386
Note
Medium Risk
Introduces a small breaking behavior change for callers who previously used
schema={}to clear/disable validation; otherwise changes are localized and low complexity.Overview
Prevents invalid schema validation configs by raising
ValueErrorwhenschemais not a non-emptydictindb.create_collection(..., schema=...)andcollection.configure(schema=...).Updates docs to state empty schemas are not allowed, adjusts collection tests to expect the new exception, makes backup formatting tolerant of missing
Status, adds a short wait after backup restore in tests, and bumps the library version to8.3.0.Written by Cursor Bugbot for commit f2984aa. This will update automatically on new commits. Configure here.