Merged
Conversation
mintsuki
reviewed
Dec 5, 2025
.gitlab-ci.yml
Outdated
|
|
||
| # We currently do not have unit tests implemented but this stage is written in anticipation of their future usage. | ||
| # When a stage name is preceeded with a '.' it's treated as "disabled" by GitLab and is not executed, so it's fine for it to be declared. | ||
| # When a stage name is proceeded with a '.' it's treated as "disabled" by GitLab and is not executed, so it's fine for it to be declared. |
Contributor
There was a problem hiding this comment.
The proper correction here is preceded, not proceeded.
mintsuki
reviewed
Dec 5, 2025
archinstall/tui/menu_item.py
Outdated
| if item.text.lower().startswith(pattern): | ||
| return 0 | ||
| return 1 | ||
|
|
Contributor
There was a problem hiding this comment.
You have code from your other PR in here, it shouldn't be here :)
Contributor
Author
There was a problem hiding this comment.
Sorry I don't know how he got here, must have wandered in himself...
mintsuki
reviewed
Dec 5, 2025
mintsuki
approved these changes
Dec 6, 2025
svartkanin
approved these changes
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
Various typo and grammar fixes across code base!
Tests and Checks